[pve-devel] [RFC qemu v3 06/34] PVE backup: add target ID in backup state

[Fiona Ebner]

On 13.11.24 10:22 AM, Fiona Ebner wrote:
> On 12.11.24 5:46 PM, Fabian Grünbichler wrote:
>> On November 7, 2024 5:51 pm, Fiona Ebner wrote:
>>> +    backup_state.target_id = g_strdup("Proxmox");
>>
>> if we take this opportunity to also support multiple PBS targets while
>> we are at it, it might make sense to make this more of a "legacy" value?
>> or not set it at all here to opt into the legacy behaviour?
>>
> 
> Why isn't "Proxmox" a good legacy value? When we add support for passing
> in a target ID to qmp_backup(), I had in mind using "PBS-$storeid" or
> something along those lines.

Also, this value is used in error messages like "previous backup by
provider %s not finished", so "Proxmox" fits there too. It was
"provider_id" early on and then changed to "target_id" for the very
reason that a single provider might want multiple bitmaps for multiple
targets, so I guess I should adapt the error message to something like
"previous backup for target %s not finished".