[pve-devel] [PATCH v2 manager] ui: acme: switch cluster view items over to those from widget-toolkit

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 12 20:47:31 CET 2024


Am 30.04.24 um 13:17 schrieb Filip Schauer:
> The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
> were copied from pve-manager in commits 5df894de and 658bfdff. This
> makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
> them and use pmxACMEAccountView & pmxACMEPluginView instead.
> 
> This leaves PVE.node.ACMEAccountView & pveACMEPluginEditor unused, so
> remove them too.
> 
> Signed-off-by: Filip Schauer <f.schauer at proxmox.com>
> ---
> Changes since v1:
> * Also switch over account view
> * Correct acmeUrl (/config/acme -> /cluster/acme)
> * Reference introduction of pmxACMEAccountView & pmxACMEPluginView in
>   commit message
> * Remove ACMEPluginEdit.js from the Makefile
> 
>  www/manager6/Makefile              |   1 -
>  www/manager6/dc/ACMEClusterView.js | 204 +-------------------------
>  www/manager6/dc/ACMEPluginEdit.js  | 223 -----------------------------
>  www/manager6/node/ACME.js          |  66 ---------
>  4 files changed, 4 insertions(+), 490 deletions(-)
>  delete mode 100644 www/manager6/dc/ACMEPluginEdit.js
> 
>

Look OK in general but needs a rebase due to a typo fix in the deleted file and
I get an exception when navigating to the Datacenter -> ACME panel, so maybe
something else changed that needs adaption here.

20:45:51.345 Uncaught neither 'url' nor both, submitUrl and loadUrl specified proxmoxlib.js:12473:6
    initComponent https://d8.work.tlmp.it:8006/proxmoxlib.js?ver=v4.3.0-t1731358651:12473
    callParent ExtJS
    initComponent https://d8.work.tlmp.it:8006/proxmoxlib.js?ver=v4.3.0-t1731358651:14055
    ExtJS 2
    constructor https://d8.work.tlmp.it:8006/proxmoxlib.js?ver=v4.3.0-t1731358651:12284
    ExtJS 17
    activateCard https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:13600
    selectionchange https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:13544
    ExtJS 39
    initComponent https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:60157
    callParent ExtJS
    initComponent https://d8.work.tlmp.it:8006/pve2/js/pvemanagerlib.js?ver=8.2.8:60615
    ExtJS 4
    <anonym> https://d8.work.tlmp.it:8006/#v1:0:18:4:10:=contentIso::30:8::=sdnmappings:41
    ExtJS 15




More information about the pve-devel mailing list