[pve-devel] [PATCH qemu-server v3 19/34] backup: keep track of block-node size for fleecing

[Fiona Ebner]

On 11.11.24 3:22 PM, Fabian Grünbichler wrote:
> On November 7, 2024 5:51 pm, Fiona Ebner wrote:
>> @@ -1042,6 +1044,31 @@ sub qga_fs_thaw {
>>      $self->logerr($@) if $@;
>>  }
>>  
>> +# The size for fleecing images needs to be exactly the same size as QEMU sees. E.g. EFI disk can bex
>> +# attached with a smaller size then the underyling image on the storage.
>> +sub query_block_node_sizes {
>> +    my ($self, $vmid, $task) = @_;
>> +
>> +    my $block_info = mon_cmd($vmid, "query-block");
>> +    $block_info = { map { $_->{device} => $_ } $block_info->@* };
>> +
>> +    for my $diskinfo ($task->{disks}->@*) {
> 
> only usage of $task
> 
> so we don't actually need to add $task as parameter to the two existing
> subs, but can just modify this here to take $task->{disks} directly? or
> did I overlook something?
> 
> if we do have to keep $task as parameter, it should come before $vmid in
> the argument list, to be consistent with the rest..
> 
> other than that, consider this patch
> 

Right, since $task->{disks} is itself a reference, this should work out
fine :)