[pve-devel] applied: [RFC manager] triggers: add path-based trigger interest

[Fabian Grünbichler]

On November 11, 2024 6:44 pm, Thomas Lamprecht wrote:
> Am 05.11.24 um 12:43 schrieb Fabian Grünbichler:
>> to avoid the need to mark every package shipping PVE-related perl code as
>> activating the explicit trigger. the explicit trigger can still be used for
>> packages that need to reload the API without shipping a perl module
>> 
>> the explicit trigger activation can be dropped in PVE 9.0 in packages that ship
>> perl code, without a need for versioned dependencies.
> 
> Not for the HA usecase.
 
the HA case could also switch over to this approach, if we want to
reload HA for all PVE perl modules.. if we only want it for a subset,
then yes, the/an explicit trigger is better :)

>> 
>> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
>> ---
>> Currently, the following packages ship perl modules in /usr/share/perl5/PVE,
>> but don't activate the explicit trigger:
>> 
>> libpve-apiclient-perl libpve-cluster-perl libpve-notify-perl pve-cluster libpve-u2f-server-perl dab
> 
> At least for libpve-notify-perl it might be nice to get a trigger so that HA
> get's restarted there too, most of the rest it would be rather superfluous for
> HA.

see above - the question is whether we want an explicit list of packages
that trigger HA (and risk that it runs out of sync with the modules the
HA actually uses), or whether we want to treat HA like the pve-manager
services, and just let it reload on any perl module changes that *could*
affect it..

if desired, I can send a similar patch for pve-ha-manager as well.