[pve-devel] [PATCH v1 pve-common 11/18] pbsclient: let `status` method return a hash instead of an array

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 11 20:17:57 CET 2024


Am 02.08.24 um 15:26 schrieb Max Carrara:
> Instead of returning an (arguably awkward) array with four elements,

can be fine, but FWIW, this is how our storage plugin system expects the
status, but currently that calls run_client_cmd itself, i.e. is basically a
copy of the original code here.

> where each element has a special meaning, return the hash that is
> constructed from the `proxmox-backup-client status` command's JSON
> output.
> 
> The documentation is updated accordingly.
> 
> This method isn't used anywhere in our code base at the moment, so I
> assume it is safe to change it. Checked with ripgrep.
> 
> Signed-off-by: Max Carrara <m.carrara at proxmox.com>
> ---
>  src/PVE/PBSClient.pm | 32 ++++++++++----------------------
>  1 file changed, 10 insertions(+), 22 deletions(-)
> 




More information about the pve-devel mailing list