[pve-devel] [PATCH v1 pve-common 09/18] pbsclient: create secret dir with `mkdir -p` and mode `700`

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 11 20:16:04 CET 2024


Am 02.08.24 um 15:26 schrieb Max Carrara:
> .. instead of using a regular `mkdir` call.
> 
> The `File::Path::make_path` subroutine is used for this purpose, which
> recursively creates all directories if they didn't exist before. Upon
> creation of those directories, the mode is also set to `700`.
> 
> This means that (like before), directory permissions are left
> untouched if the directory existed already.

this is already enforced by pmxcfs for our case though?

And not sure about making the whole base path 0700, might be better
to create only the last directory as such? but this is generally something
where IMO lots can go wrong with little benefit, so not so sure about
this one.





More information about the pve-devel mailing list