[pve-devel] applied-series: [PATCH docs/widget-toolkit/manager v3] implement tagview

[Dominik Csapak]

On 11/10/24 12:22, Thomas Lamprecht wrote:
> Am 07.11.24 um 12:25 schrieb Dominik Csapak:
>> this adds a 'tagview' to the web ui, organizing guests by their tags
>> (for details see the pve-manager patch)
>>
>> I'm not super happy all in all with how much special casing must be
>> done, but i could not (yet?) figure out a better way.
>>
>> changes from v2:
>> * rebased on master (tooltip generation changed so adapted to that)
>> * implemented fionas feedback, so selection should stay even when tags
>>    are removed or the selection is changed from the tag view
>>
>> changes from v1:
>> * rebase on master
>> * adapt to recent tooltip changes
>> * add a comment to TagConfig class to better explain what it does
>>
>> pve-docs:
>>
>> Dominik Csapak (1):
>>    gui: add anchor for tags chapter
>>
>>   pve-gui.adoc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> proxmox-widget-toolkit:
>>
>> Dominik Csapak (1):
>>    css: add some conditions to the tag classes for the tag view
>>
>>   src/css/ext6-pmx.css | 22 +++++++++++++++-------
>>   1 file changed, 15 insertions(+), 7 deletions(-)
>>
>> pve-manager:
>>
>> Dominik Csapak (1):
>>    ui: implement 'Tag View' for the resource tree
>>
>>   www/manager6/Makefile             |  1 +
>>   www/manager6/Workspace.js         |  4 +-
>>   www/manager6/form/ViewSelector.js | 28 +++++++++++
>>   www/manager6/grid/ResourceGrid.js |  2 +-
>>   www/manager6/panel/TagConfig.js   |  6 +++
>>   www/manager6/tree/ResourceTree.js | 81 ++++++++++++++++++++++++++++---
>>   6 files changed, 113 insertions(+), 9 deletions(-)
>>   create mode 100644 www/manager6/panel/TagConfig.js
>>
> 
> 
> applied, thanks!
> 
> What would be nice to have is to optionally show also nodes and storage entries
> for the tag and pool views, so that these views can be used as only one to fully
> manage all resources. This probably should even become an opt-out setting.

that should be (relatively) easy, so I'll whip something up. any preferred
order on the types on the same level (i.e. do you want the nodes/storages
below the untagged/unpooled guests, or above?)

> 
> semi-related, allowing one to group (shared) storages with the same name might
> also be great to make the resource tree clearer and quicker to find things if
> one has more than a few nodes/storages. I.e., I'd join the list of nodes in the
> tree where the current node name is and add a node selector filtered to the
> available nodes in the storage view to allow selecting another node, that way
> we might even group storages that are distinct on every node, or leave that up
> to select, i.e.:
> 
> Group Storages: [ Default (No) ]
>                  | No           |
>                  | Shared Only  |
>                  | All          |

ok, i think i understand what you want here, but not sure how much work that is.
Currently we only have one 'grouping' per view so to introduce 'grouping per type'
is probably not that easy...

I'll see how it could work regardless

do i understand correctly that this would not exist in the server view,
only in tag/pool/folder ?
(where multiple storages with the same name appear on the same level)