[pve-devel] [PATCH common] inotify: avoid cyclic use statement

[Fiona Ebner]

Am 11.11.24 um 12:49 schrieb Stefan Hanreich:
> On 8/2/24 13:53, Fiona Ebner wrote:
>> @Stefan: Do you have any good rationale to rather keep the check?
> 
> maybe change it from log_warn to warn? I can send a patch if you like.

See the commit message:

>> The rest of the PVE::INotify module alredy uses syslog(), which could
>> be used here as well to get rid of the cyclic usage. Wolfgang argued
>> that the whole point of commit e68ebda was to remove coupling between
>> the name and the type of the interface. If there still is some code
>> about a name starting with 'vmbr' being classified wrong, that should
>> rather be fixed. Because of the very commit, the frontend already
>> doesn't show e.g. a non-bridge with name 'vmbr7' in bridge selectors.

If we keep it, syslog() is better than warn here. But why is it better
for the check to be there than not (like Wolfgang suggested)?