[pve-devel] applied-series: [PATCH manager v2 1/2] ui: cloudinit: use cloudinit update api when regenerating images

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Nov 10 19:59:59 CET 2024


Am 07.11.24 um 15:40 schrieb Daniel Kral:
> Changes the behavior of the "Regenerate Image" button in the VM's
> CloudInit tab from using the more expensive VM update API endpoint to
> using the CloudInit update API endpoint.
> 
> Originally-by: Alexandre Derumier <alexandre.derumier at groupe-cyllene.com>
> Signed-off-by: Daniel Kral <d.kral at proxmox.com>
> ---
> Changes since v1 (as suggested by @Fiona):
>     - added this patch to reduce the needed permissions
>     - added a commit message to the applied patch
>     - no changes to the original patch hunk
> 
> This change has been taken from a previously unapplied commit [0]. I
> have only applied the changes done to the button handler.
> 
> The rest of the original patch also touches the functionality of editing
> the fields, which breaks the check if a cloudinit disk is present,
> because the cloudinit_pending's response no longer includes the
> CloudInit disk drive property itself and therefore will always show "No
> CloudInit drive found". This change could be included in the future, but
> is not part of my original patch's intention.
> 
>  www/manager6/qemu/CloudInit.js | 32 +++++---------------------------
>  1 file changed, 5 insertions(+), 27 deletions(-)
> 
>

applied both patches, thanks! FWIW, I made a small follow-up to go for a shorter
"show alert on failure"  callback, as this file still used the older style from
before the time we could use arrow-fns.




More information about the pve-devel mailing list