[pve-devel] [PATCH installer v2 0/3] properly filter out all installer-related kernel arguments

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Nov 10 19:38:20 CET 2024


Am 21.08.24 um 15:22 schrieb Christoph Heiss:
> Friedrich recently reported that when installing using the
> auto-installer, the kernel commandline does not get cleaned up properly.
> 
> For building/testing on current master, [0] needs to be applied
> beforehand to fix a test failure.
> 
> [0] https://lists.proxmox.com/pipermail/pve-devel/2024-July/064815.html
> 
> history
> =======
> 
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-August/065070.html
> 
> Notable changes v1 -> v2:
>   * parse whole line by splitting and then filtering out individually
>   * add some tests
> 
> git diffstat
> ============
> 
> Christoph Heiss (3):
>   low level: config: filter out kernel cmdline on word boundaries
>   low level: config: filter out all installer-related kernel arguments
>   test: add test for kernel commandline parsing
> 
>  Proxmox/Install/Config.pm    | 11 ++++---
>  test/Makefile                |  7 +++-
>  test/parse-kernel-cmdline.pl | 62 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 75 insertions(+), 5 deletions(-)
>  create mode 100755 test/parse-kernel-cmdline.pl
> 


can you please rebase this and also check if it adheres to the recent slight
change in not filtering out nomodeset anymore?

https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=49219542da0e2a5e52dc83455466868cd0d5b25d




More information about the pve-devel mailing list