[pve-devel] [PATCH installer v2 0/4] auto-install-assistant: allow specifying 'fetch-from' partition label
Christoph Heiss
c.heiss at proxmox.com
Fri Nov 8 14:05:32 CET 2024
This series allow specifying the partition label the
`proxmox-fetch-answer` tool will search when trying to retrieve an
answer file in the 'partition' fetch mode.
This has been requested by at least one user one user [0] and definitely
makes sense, esp. for BMCs/IPMIs where one might not be able to control
the partition label.
Patch #1 implements the new CLI parameter in the
`proxmox-auto-install-assistant` tool, patch #4 then integrates it into
the `proxmox-fetch-answer` itself. Patch #2 is just a small (but needed)
refactor of the CLI parsing code.
Patch #3 implements also searching for the partition label in the exact
case it was specified by the user. This is something I stumbled over
while testing it - see the patch itself for some more information.
[0] https://forum.proxmox.com/threads/proxmox-ais-question-request.153043/post-695689
History
=======
v1: https://lore.proxmox.com/pve-devel/20241018115943.813243-1-c.heiss@proxmox.com/
Notable Changes v1 -> v2:
* addressed suggestions by Aaron
* added Aaron's T-b & R-b tags, thanks!
* dropped useless "proxmox-ais" explanation from --prepare-iso
description
Diffstat
========
Christoph Heiss (4):
auto-install-assistant: add new parameter to specify partition label
fetch-answer: refactor cli argument parsing
fetch-answer: partition: also search for exact-matching partition
label
fetch-answer: use partition label from fetch config instead of
hardcoded
proxmox-auto-install-assistant/src/main.rs | 15 ++++-
proxmox-auto-installer/src/utils.rs | 1 +
.../src/fetch_plugins/partition.rs | 32 ++++++----
proxmox-fetch-answer/src/main.rs | 58 ++++++++++++++-----
4 files changed, 80 insertions(+), 26 deletions(-)
--
2.46.0
More information about the pve-devel
mailing list