[pve-devel] [PATCH container v2] api: record CT ID as used after a container is destroyed

Severen Redwood severen.redwood at sitehost.co.nz
Tue Nov 5 01:53:41 CET 2024


Hi Aaron,

On Thu, Oct 31, 2024 at 06:27:43PM +0100, Aaron Lauterer wrote:
> This is missing a
> 
> use PVE::UsedVmidList;
> 
> at the top of the file. Otherwise running
> 
> pct destroy {vmid}
> 
> will result in the following error:
> 
> Undefined subroutine &PVE::UsedVmidList::add_vmid called at
> /usr/share/perl5/PVE/API2/LXC.pm line 799.
> 
> This doesn't seem to be necessary in the qemu-server repo, but I did not
> investigate further how pulling in dependencies works there.

Thanks for catching this! It's strange that it's not necessary in
`PVE::API2::Qemu`... Either way, I think it makes sense to explicitly use the
module in both files, so I'll update the patches to do that.

Thanks,
Severen



More information about the pve-devel mailing list