[pve-devel] [PATCH qemu-server] api: snapshot create/delete/rollback: print log line that mentions snapshot name

[Fabian Grünbichler]

On May 29, 2024 1:07 pm, Dominik Csapak wrote:
> On 5/29/24 12:09, Fabian Grünbichler wrote:
>> On May 29, 2024 11:20 am, Dominik Csapak wrote:
>>> so that an admin can see from the task logs which snapshot was rolled
>>> back/created/removed without the need to look into the journal (to which
>>> the admin might not have access to).
>> 
>> good idea in general, but wouldn't it be better to log it before
>> attempting the operation, so that the context is in the task log
>> irrespective of how a potential error message looks like?
> 
> i'd probably log both

logging the end doesn't give you much (if the name is mentioned earlier
already), since the task already has a status, so it's (heavily) implied
;) but it also doesn't really hurt :)

>> (side note, we might want to think about making the whole snapshot
>> process a bit more verbose? i.e., log the individual parts as well?)
> 
> i noticed that i missed doing that for containers .
> also for some storages there is already output (e.g. ceph logs the
> snapshot progress)
> 
> For a v2 i'd do the logging in 'snapshot_create' etc. in AbstractConfig,
> that should handle both vms and ct, and there we can print between
> phases too
> 
> does that sound ok?

sure!