[pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID

[Thomas Lamprecht]

Am 17/05/2024 um 13:21 schrieb Dominik Csapak:
> one small nit inline:
> 
> On 5/10/24 13:47, Markus Frank wrote:
>> diff --git a/query-machine-capabilities/Makefile b/query-machine-capabilities/Makefile
>> new file mode 100644
>> index 0000000..c5f6348
>> --- /dev/null
>> +++ b/query-machine-capabilities/Makefile
>> @@ -0,0 +1,21 @@
>> +DESTDIR=
>> +PREFIX=/usr
>> +SBINDIR=${PREFIX}/libexec/qemu-server
>> +SERVICEDIR=/lib/systemd/system
>> +
> 
> PREFIX is only used once here, so it's probably better inlining the value

No, having the PREFIX variable separate is a common pattern
that allows customizing installation.
Even if we do not need that ourselves, it's still not costing us really
anything to keep following that here and could make comparing changes
between two packages with binaries installed in different paths easier.
So while I wouldn't go through all our build systems and introduce this
variable if missing, I'd also not recommend developers to drop it, as it
is not better to do so.