[pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV

Dominik Csapak d.csapak at proxmox.com
Fri May 17 13:21:44 CEST 2024


all in all the series looks mostly good to me with some minor comments
(see comments on the individual patches)
i could not test it since i don't have an amd epyc system here ;)


one high level thing though (but no hard feelings)

is the systemd service really necessary ?

we could simply call the binary the first time it's needed?

so in qemu-server:

---
if (! -e $cap_path) {
    # executing the binary
}
---

before we try to parse it ?

we can still make it a service should we need, but IMHO this seems
overkill for the current use case




More information about the pve-devel mailing list