[pve-devel] applied: [PATCH qemu-server] schema: fix description of migrate_downtime parameter

Fiona Ebner f.ebner at proxmox.com
Mon May 6 09:53:33 CEST 2024


Am 03.05.24 um 19:36 schrieb Thomas Lamprecht:
> On 03/05/2024 14:01, Fiona Ebner wrote:
>> Since commit 865ef132 ("implement dynamic migration_downtime") the
>> migration downtime will be automatically increased when migration
>> cannot converge at the very end. Update the description to reflect
>> reality.
>>
>> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
>> ---
>>  PVE/QemuServer.pm | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>>
> 
> applied, thanks! we might deprecate this option then, as a user cannot
> force a minimal downtime anyway anymore through it, and not sure how
> much use it has to set the initial value.
> 

If the network is fast enough, the option can still be useful, because
then the downtime will be effectively shorter (than our default).
Another idea would be to make it a property string and allow setting
enforce=true (or auto-increase=false). See the related discussion here:
https://forum.proxmox.com/threads/146237/post-660507

> Deprecating would for now mostly mean adding that word to the description
> though, so no biggie.




More information about the pve-devel mailing list