[pve-devel] [PATCH-SERIES qemu-server/manager] fix #5440: HMP/disk timeout improvements

Fiona Ebner f.ebner at proxmox.com
Fri May 3 13:19:49 CEST 2024


Currently, all HMP commands (issued as a "human-monitor-command" QMP
command) use the default timeout for QMP commands of just 5 seconds.

For drive-related commands, this is not always enough, as reported in
bug #5440. Other drive-related QMP commands use 10 minutes, so it is
natural to increase the limit for the HMP command for detaching a
drive to that too.

Other HMP commands that are issued are limited by being in a
synchronous API call or interactive monitor session, but can still
benefit from an increased timeout over the 5 second default.

Lastly, the UI is adapted to use the asynchronous API call when
hot-unplugging a drive, to be more in-line with the backend.


qemu-server:

Fiona Ebner (5):
  monitor: allow passing timeout for a HMP command
  api: human monitor: increase timeout to 25 seconds
  vzdump: increase timeout for attaching drives to 60 seconds
  cli: qm: increase timeout for monitor commands to 30 seconds
  fix #5440: hmp helpers: drive{add,del}: increase timeout

 PVE/API2/Qemu.pm          | 2 +-
 PVE/CLI/qm.pm             | 2 +-
 PVE/QemuServer.pm         | 4 ++--
 PVE/QemuServer/Monitor.pm | 4 ++--
 PVE/VZDump/QemuServer.pm  | 4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)


pve-manager:

Fiona Ebner (2):
  ui: qemu: hardware: use background delay for asynchronous remove tasks
  ui: qemu: hardware: use asynchronous remove API call for disk
    hot-unplug

 www/manager6/qemu/HardwareView.js | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

-- 
2.39.2





More information about the pve-devel mailing list