[pve-devel] [PATCH v2 pve-manager 3/4] fix #5255: node: wol: configurable broadcast address

[Christian Ebner]

Allows to configure a custom broadcast address to use when sending a
wake on lan packet to wake a remote node.

Default behaviour remains to fallback to 255.255.255.255.

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
changes since version 1:
- Adapted to use property string

 PVE/API2/Nodes.pm | 3 ++-
 PVE/NodeConfig.pm | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 9ffe7494..4f9640b2 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -700,11 +700,12 @@ __PACKAGE__->register_method({
 	my $local_config = PVE::NodeConfig::load_config($local_node);
 	my $local_wol_config = PVE::NodeConfig::get_wakeonlan_config($local_config);
 	my $bind_iface = $local_wol_config->{'bind-interface'};
+	my $broadcast_addr = $local_wol_config->{'broadcast-address'} // '255.255.255.255';
 
 	$mac_addr =~ s/://g;
 	my $packet = chr(0xff) x 6 . pack('H*', $mac_addr) x 16;
 
-	my $addr = gethostbyname('255.255.255.255');
+	my $addr = gethostbyname($broadcast_addr);
 	my $port = getservbyname('discard', 'udp');
 	my $to = Socket::pack_sockaddr_in($port, $addr);
 
diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm
index ee316296..5fa8001c 100644
--- a/PVE/NodeConfig.pm
+++ b/PVE/NodeConfig.pm
@@ -110,6 +110,13 @@ my $wakeonlan_desc = {
 	format_description => 'bind interface',
 	optional => 1,
     },
+    'broadcast-address' => {
+	type => 'string',
+	description => 'IPv4 broadcast address to use when sending wake on LAN packet',
+	format => 'ipv4',
+	format_description => 'IPv4 broadcast address',
+	optional => 1,
+    },
 };
 
 $confdesc->{wakeonlan} = {
-- 
2.39.2