[pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug

[Fiona Ebner]

Am 25.03.24 um 11:29 schrieb Fiona Ebner:
> 
> After shutdown+start, the hotplug worked as expected. Played around a
> bit more and something strange happened with LVM as the storage: While
> it worked the first time, when I shut down the container, detached the
> mount point, started again and then tried to hot-plug, I got:
> mp1: unable to hotplug mp1: command 'mount /dev/lvm/vm-129-disk-1
> /var/lib/lxc/.pve-staged-mounts/mp1' failed: exit code 32
> 
> Doesn't seem to happen with ZFS or directory storage and starting with
> the mount point pre-attached also worked fine with previously written
> files still there.
> 
> Also booted into 6.2.16-20-pve, installed unpatched pve-container and it
> seems the issue was already present then.
> 

After looking into this, it's likely because the LV is deactivated after
the shutdown. Apparently we're missing the activate_volume() call before
doing a hotplug.