[pve-devel] [PATCH pve-network 0/8] SDN Vnet blackbox testing
Max Carrara
m.carrara at proxmox.com
Mon Mar 18 13:41:21 CET 2024
On Wed Jan 3, 2024 at 4:37 PM CET, Stefan Lendl wrote:
> Add several tests for Vnets. State setup as well as testing results is
> done only via the API to test on the API boundaries not not against the
> internal state. Internal state is mocked to avoid requiring access to
> system files or pmxcfs.
>
> Tests validate the events of a nic joining a Vnet or a nic staring on a vnet
> with different subnet configurations.
> Further descriptions in the commit.
I really like this! I'm always a fan of more testing being done.
There are some things I mentioned in patch 8, but I overall like this
series a lot.
>
> Stefan Lendl (8):
> refactor(sdn): extract cfs_read_file(datacenter.cfg)
> refactor(dnsmasq): extract systemctl_service function
> refactor(dnsmasq): extract ethers_file function
> refactor(dnsmasq): extract update_lease function
> refactor(controllers): extract read_etc_network_interfaces
> refactor(evpn): extract read_local_frr_config
> refactor(api): extract create_etc_interfaces_sdn_dir
The naming here could be a little different though; I think you can just
skip the `refactor()` part, we don't really use that anywhere AFAIK.
> test(vnets): add test_vnets_blackbox
Also, for this message you could just use "test: vnets: ..." instead.
See also: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
>
> src/PVE/API2/Network/SDN/Zones.pm | 6 +-
> src/PVE/Network/SDN/Controllers.pm | 16 +-
> src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 10 +-
> src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 47 +-
> src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 3 +-
> src/PVE/Network/SDN/Zones/Plugin.pm | 5 +
> src/PVE/Network/SDN/Zones/SimplePlugin.pm | 2 +-
> src/test/Makefile | 5 +-
> src/test/run_test_vnets_blackbox.pl | 797 ++++++++++++++++++
> 9 files changed, 863 insertions(+), 28 deletions(-)
> create mode 100755 src/test/run_test_vnets_blackbox.pl
More information about the pve-devel
mailing list