[pve-devel] applied: [PATCH qemu] fix patch for accepting NULL qiov when padding

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 12 13:14:48 CET 2024


Am 12/03/2024 um 09:47 schrieb Fiona Ebner:
> All callers of the function pass an address, so dereferencing once
> before checking for NULL is required. It's also necessary to update
> bytes and offset nevertheless, so the request will actually be aligned
> later and not trigger an assertion failure.
> 
> Seems like this was accidentally broken in 8dca018 ("udpate and rebase
> to QEMU v6.0.0") and this is effectively a revert to the original
> version of the patch. The qiov functions changed back then, which
> might've been the reason Stefan tried to simplify the patch.
> 
> Should fix live-import for certain kinds of VMDK images.
> 
> Reported-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  ...accept-NULL-qiov-in-bdrv_pad_request.patch | 59 ++++++++++++++-----
>  1 file changed, 45 insertions(+), 14 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list