[pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

[Hannes Dürr]

On 3/6/24 15:04, Fiona Ebner wrote:
> Yes, but the question is what is worse: Needing to re-do the clone or
> having the VM config on the wrong node?
>
>> To avoid that, I'd lean towards keeping the behavior of failing the task
>> if deactivating $newvollist fails. After all, at least in case of LVM
>> not being able to deactivate because the device is in use, we just
>> created $newvollist so hopefully nobody else should be accessing it.
> Fine by me. Yes, it's unlikely to fail. And we can still adapt later if
> users ever complain about it.

I've sent a v2 
https://lists.proxmox.com/pipermail/pve-devel/2024-March/062115.html

Also, i agree with friedrich, but yes, it should be very unlikely to fail.