[pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

Dietmar Maurer dietmar at proxmox.com
Fri Mar 1 10:45:37 CET 2024


> On 29.2.2024 16:09 CET Roland Kammerer via pve-devel <pve-devel at lists.proxmox.com> wrote:
> All in all, yes, this is specific for our use case, otherwise
> parse_volname would already have that additional parameter as all the
> other plugin functions, but I don't see where this would hurt existing
> code, and it certainly helps us to enable reassigning disks to VMs.
> Passing in a param all other functions already get access to also does
> not sound too terrible to me.
> 
> If there are further questions please feel free to ask.

Are you aware that parse_volname() is sometimes called for
all volumes, i.e inside volume_is_base_and_used().

Would that be fast enough? IMHO its a bad idea to make a network query for each volume there...




More information about the pve-devel mailing list