[pve-devel] [PATCH qemu-server] fix #5543: pci: don't use pci devices when starting templates

[Dominik Csapak]

On 6/19/24 10:17, Fiona Ebner wrote:
> Am 19.06.24 um 10:14 schrieb Fiona Ebner:
>> I'd be in favor of fixing this together with
>> https://bugzilla.proxmox.com/show_bug.cgi?id=3352
>> and use a minimal QEMU commandline that only attaches the block devices
>> and nothing else. I guess the addition for the PCI cleanup is still
>> needed, but getting the minimal commandline is probably best done as a
>> new helper. What do you think?
>>
> 
> Another way would be to reduce the config we pass to config_to_command
> to only the block devices and 1 CPU, etc.. Maybe that's more
> straight-forward than a new helper.


yeah, some combined fix for that would be good, did not have that bug on my
radar.

I agree that 'minifying' the config is probably the way to go here,
but as you said, the cleanup should also be touched so it does not
throw warnings for not available devices etc.

I think we could have a set of keys as a whitelist to copy, and leave all
others default, i think for starters we should whitelist:

* all disk configs (excl. cdroms)
* the kvm setting
* anything else ?