[pve-devel] [PATCH installer v2 0/4] assistant: clean up glob patterns & regexes
Christoph Heiss
c.heiss at proxmox.com
Mon Jun 17 09:11:53 CEST 2024
Ping. Still applies cleanly.
On Mon, May 13, 2024 at 11:49:08AM +0200, Christoph Heiss wrote:
> The proxmox-auto-install-assistant uses
> - glob patterns for disk matching, which can be pre-compiled for
> efficiency
> - regexes for udev property matching, which can be simplified by some
> simple prefix matching & splitting on =
>
> The latter also significantly reduces binary size due to the removing
> the regex dependency, for details see patch #4.
>
> Overall no functional changes in this series.
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html
>
> Changes v1 -> v2:
> * rebased on latest master
>
> Christoph Heiss (4):
> tree-wide: run rustfmt, fix clippy warnings
> assistant: drop unused `log` dependency
> assistant: pre-compile ignored block device patterns
> assistant: avoid regex for simple prefix matching
>
> proxmox-auto-install-assistant/Cargo.toml | 2 -
> proxmox-auto-install-assistant/src/main.rs | 75 ++++++++-----------
> proxmox-auto-installer/tests/parse-answer.rs | 14 ++--
> .../src/fetch_plugins/partition.rs | 10 +--
> 4 files changed, 45 insertions(+), 56 deletions(-)
>
> --
> 2.44.0
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
More information about the pve-devel
mailing list