[pve-devel] applied: [PATCH v2 pve-qemu-kvm] patches: pbs block driver: correct a data type

Fiona Ebner f.ebner at proxmox.com
Mon Jun 10 16:12:08 CEST 2024


Am 10.06.24 um 14:05 schrieb Jing Luo:
> gcc warns (-Werror=type-limits) that it will always be false for the
> if statement. This is because here s->aid is defined as char, while
> proxmox_restore_open_image() returns an int.
> 
> This is probably because chars are treated as unsigned on arm arch but
> signed on x86 arch:
> 
> https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char
> 
> Signed-off-by: Jing Luo <jing at jing.rocks>
> --

applied, thanks!

Here, a '-' was missing, so the below stuff would still be interpreted
as part of the commit message. I fixed that when applying, improved the
message slightly and made a follow-up to have a dedicated error message
for when the returned value is too large.

Best Regards,
Fiona




More information about the pve-devel mailing list