[pve-devel] [PATCH installer 0/7] use email regex from HTML spec for validation

[Max Carrara]

On Tue May 28, 2024 at 10:13 AM CEST, Christoph Heiss wrote:
> This uses the regex for <input type="email" /> elements as defined in
> the HTML spec to validate emails in the installer. That regex should be
> a lot more robust than our current on and cover basically all cases of
> email addresses that might be encountered in the while.
>
> Also, patch #6 adds validation for the auto-installer `global.mailto`
> option too, while at it.
>
> Patches #1 through #4 are just small cleanups/fixes and may be applied
> independently.
>
> [0] https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address

The changes in this series are rather straightforward; there's nothing
extraordinary going on. LGTM.

Reviewed-by: Max Carrara <m.carrara at proxmox.com>

>
> Christoph Heiss (7):
>   cargo: convert `anyhow` to workspace dependency
>   tui: fix new clippy lint
>   auto-installer: drop some unneeded `pub` modifiers
>   auto-installer: print full anyhow message on failure
>   tui: use email regex from HTML specification for validation
>   auto-installer: validate `global.mailto` answer option
>   proxinstall: use email regex from HTML specification for validation
>
>  Cargo.toml                                    |  2 ++
>  Proxmox/Makefile                              |  1 +
>  Proxmox/Sys.pm                                |  9 ++++++
>  proxinstall                                   |  3 +-
>  proxmox-auto-install-assistant/Cargo.toml     |  2 +-
>  proxmox-auto-installer/Cargo.toml             |  2 +-
>  .../src/bin/proxmox-auto-installer.rs         |  2 +-
>  proxmox-auto-installer/src/utils.rs           | 17 ++++++-----
>  proxmox-chroot/Cargo.toml                     |  2 +-
>  proxmox-fetch-answer/Cargo.toml               |  2 +-
>  proxmox-installer-common/Cargo.toml           |  1 +
>  proxmox-installer-common/src/options.rs       | 29 ++++++++++++++++++-
>  proxmox-tui-installer/Cargo.toml              |  1 -
>  proxmox-tui-installer/src/main.rs             | 22 +++++---------
>  14 files changed, 65 insertions(+), 30 deletions(-)
>  create mode 100644 Proxmox/Sys.pm