[pve-devel] applied: [PATCH qemu-server] drive mirror: prevent wrongly logging success when completion fails differently

[Thomas Lamprecht]

Am 23/07/2024 um 14:07 schrieb Fiona Ebner:
> Currently, when completing a drive mirror job, only errors matching
> "cannot be completed" will be handled. Other errors are ignored and
> a wrong message that the job was completed successfully will be
> printed to the log. An instance of this popped up in the community
> forum [0].
> 
> The QMP command used for completing the job is either
> 'block-job-complete' or 'block-job-cancel'. The former causes the VM
> to switch to the target drive, the latter doesn't, e.g. migration uses
> the latter to not switch the source instance over to the target drive.
> The 'block-job-cancel' command doesn't even have the same "cannot be
> completed" message, but returns immediately.
> 
> The timeout for both 'block-job-cancel' and 'block-job-complete' is
> set to 10 minutes in the QMPClient module, which should be enough.
> 
> [0]: https://forum.proxmox.com/threads/151518/
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  PVE/QemuServer.pm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 

applied, thanks!