[pve-devel] applied: [PATCH pve-manager] sdn: vnets: Hide irrelevant fields depending on zone type

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 30 20:01:59 CEST 2024


Am 22/12/2023 um 11:43 schrieb Stefan Hanreich:
> Not all fields in the VnetEdit dialog are necessary for every zone
> type. This lead to confusion for some users. Hide fields in the
> VNetEdit dialog depending on which kind of zone is selected in order
> to prevent potential confusion.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
> ---
>  www/manager6/form/SDNZoneSelector.js |  2 +-
>  www/manager6/sdn/VnetEdit.js         | 40 ++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

albeit, it might be slightly nicer to also disable the field when it's not
relevant, as then any validation handling cannot make the form invalid without
the user seeing why nor being able to fix it.

As you clear the value to a safe one for this specific fields, it should be
not cause any issues here though.




More information about the pve-devel mailing list