[pve-devel] [PATCH pve-xtermjs v3] termproxy: allow to use unix sockets for auth requests

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 25 18:21:47 CEST 2024


On 24/07/2024 13:33, Dietmar Maurer wrote:
> Remove ureq, because it does not support unix sockets.
> 
> Signed-off-by: Dietmar Maurer <dietmar at proxmox.com>
> ---
> 
> Changes sinve v2:
>   split out the command line help text change into patch:
>   [PATCH pve-xtermjs] termproxy: fix the command line help text
> 
> Changes since v1:
> 
>  - use extra --authsocket cli option

FYI: I renamed this and the pre-existing --authport option to --auth-socket and
--auth-port, respectively, with the latter getting a fallback to the old variant
for backward compat.

And yeah I know that this in borderline useless as it's just an internal tool,
but I got a few spare minutes in the train where starting something more involved
was not justified, and making this consistent with the `--port-as-fd` option
and our modern CLI option style in general felt like an OK clean-up to do.

Anyhow, now bumped and uploaded as proxmox-termproxy in version 1.1.0.




More information about the pve-devel mailing list