[pve-devel] [PATCH docs] passthrough: viommu: remove 'amd_iommu=on' from the docs

Fiona Ebner f.ebner at proxmox.com
Wed Jul 24 11:59:22 CEST 2024


Am 26.04.24 um 09:58 schrieb Dominik Csapak:
> this is wrong and does nothing, see previous commit:
> 0c54d61 (remove 'amd_iommu=on' from the passthrough docs)
> and
> https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  qm-pci-passthrough.adoc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
> index bbd6b85..14f7fa5 100644
> --- a/qm-pci-passthrough.adoc
> +++ b/qm-pci-passthrough.adoc
> @@ -511,8 +511,7 @@ There are currently two vIOMMU implementations available: Intel and VirtIO.
>  
>  Host requirement:
>  
> -* Add `intel_iommu=on` or `amd_iommu=on` depending on your CPU to your kernel
> -command line.
> +* Add `intel_iommu=on` depending on your CPU to your kernel command line.
>  

IMHO saying "For Intel CPUs, add ..." sounds nicer than "add ...
depending on your CPU" together with your change. And we could also
mention that it's only required for kernels before 6.8 and nothing for
AMD CPUs?

>  Intel vIOMMU
>  ^^^^^^^^^^^^




More information about the pve-devel mailing list