[pve-devel] [PATCH widget-toolkit v3 7/6 follow-up] Network: add explanation for bridge vids field
Aaron Lauterer
a.lauterer at proxmox.com
Tue Jul 23 15:33:13 CEST 2024
Make clear that it affects only out-/inbound traffic and can be used if
the underlying physical NICs support only a limited number of VLANs when
offloading is possible.
Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
After some off-list discussion with @Stefan Hanreich after his review,
we came to the conclusion that some explanation is needed to avoid
confusion.
I am not too happy with how long the explanation is, if someone has a
better idea to transport that information, I am absolutely not opposed
to it.
src/node/NetworkEdit.js | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index 8c1b135..1149dee 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -109,6 +109,12 @@ Ext.define('Proxmox.node.NetworkEdit', {
return true;
},
});
+ let vidsExplanation = Ext.create('Ext.form.field.Display', {
+ disabled: true,
+ userCls: 'pmx-hint',
+ value: 'Use if you want the bridge ports to only forward a limited number of ' +
+ 'VLANs or the physical NICs support a limited number of offloaded VLANs.',
+ });
column2.push({
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('VLAN aware'),
@@ -118,6 +124,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
change: function(f, newVal) {
if (me.bridge_set_vids) {
vids.setDisabled(!newVal);
+ vidsExplanation.setDisabled(!newVal);
}
},
},
@@ -133,6 +140,7 @@ Ext.define('Proxmox.node.NetworkEdit', {
});
if (me.bridge_set_vids) {
advancedColumn2.push(vids);
+ advancedColumn2.push(vidsExplanation);
}
} else if (me.iftype === 'OVSBridge') {
column2.push({
--
2.39.2
More information about the pve-devel
mailing list