[pve-devel] applied: [PATCH manager] fix #5010: ceph: pool set only changed properties

Aaron Lauterer a.lauterer at proxmox.com
Tue Jul 23 09:50:58 CEST 2024



On  2024-07-22  19:02, Thomas Lamprecht wrote:
> 
> applied, thanks, one question still inline though.
> 
> 
>> +	if (defined($current_properties->{$setting}) && $value eq $current_properties->{$setting}) {
> hmm, might this cause trouble (or at least noisy warnings) with properties
> that are defined as integers in the schema (if we even convert those, not
> sure from top of my head) or is this always in string form here?

I might be missing some Perl intricacies here, but in all my tests it 
worked fine.

The following test also works:

perl -e 'use strict; use warnings; my $a = "1"; my $b = 1; if ($a eq $b) 
{ print "YAY" };'

Even if I set `$b = 1.0`




More information about the pve-devel mailing list