[pve-devel] applied: [PATCH qemu-server] fix #5574: api: fix permission check for 'spice' usb port

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jul 22 19:38:27 CEST 2024


Am 08/07/2024 um 13:56 schrieb Dominik Csapak:
> With the last change in the permission check, I accidentally broke the
> check for 'spice' host value, since in the if/elsif/else this will fall
> through to the else case which was only intended for when neither 'host'
> nor 'mapping' was set.
> 
> This made 'spice' only settable by root at pam since there we return early.
> 
> To fix this, move the spice check into the 'host' branch, but only error
> out in case it's not spice.
> 
> Fixes: e3971865 (enable cluster mapped USB devices for guests)
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/API2/Qemu.pm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list