[pve-devel] applied: [PATCH qemu-server 1/2] config: net: avoid duplicate ipam entries on nic update

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jul 22 18:39:07 CEST 2024


Am 17/07/2024 um 15:06 schrieb Stefan Hanreich:
> Updating the NIC of a VM when the following conditions were met:
> * VM is turned off
> * NIC is on a bridge that uses automatic dhcp
> * Leave bridge unchanged
> 
> led to duplicate IPAM entries for the same network device.
> 
> This is due to the fact that the add_next_free_cidr always ran on
> applying pending network changes.
> 
> Now we only add a new ipam entry if either:
> * the value of the bridge or mac address changed
> * the network device has been newly added
> 
> This way no duplicate IPAM entries should get created.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
> ---
>  PVE/QemuServer.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list