[pve-devel] [RFC pve-storage 01/36] plugin: base: remove old fixme comments
Max Carrara
m.carrara at proxmox.com
Wed Jul 17 11:39:59 CEST 2024
These have been around since 2012 - suffice to say they're not needed
anymore.
Signed-off-by: Max Carrara <m.carrara at proxmox.com>
---
src/PVE/Storage/Plugin.pm | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 6444390..3219f1f 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -299,19 +299,6 @@ sub parse_lvm_name {
return $name;
}
-# fixme: do we need this
-#PVE::JSONSchema::register_format('pve-storage-portal', \&verify_portal);
-#sub verify_portal {
-# my ($portal, $noerr) = @_;
-#
-# # IP with optional port
-# if ($portal !~ m/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}(:\d+)?$/) {
-# return undef if $noerr;
-# die "value does not look like a valid portal address\n";
-# }
-# return $portal;
-#}
-
PVE::JSONSchema::register_format('pve-storage-portal-dns', \&verify_portal_dns);
sub verify_portal_dns {
my ($portal, $noerr) = @_;
@@ -457,12 +444,6 @@ sub decode_value {
}
}
- # fixme:
- # no node restrictions for local storage
- #if ($storeid && $storeid eq 'local' && scalar(keys(%$res))) {
- # die "storage '$storeid' does not allow node restrictions\n";
- #}
-
return $res;
} elsif ($key eq 'content-dirs') {
my $valid_content = $def->{content}->[0];
--
2.39.2
More information about the pve-devel
mailing list