[pve-devel] [PATCH installer 00/14] fix #5536: implement post-(auto-)installation notification mechanism

Christoph Heiss c.heiss at proxmox.com
Wed Jul 17 09:25:20 CEST 2024


On Tue, Jul 16, 2024 at 06:09:17PM GMT, Thomas Lamprecht wrote:
> Am 15/07/2024 um 16:31 schrieb Christoph Heiss:
> > With that in mind it definitely could come in handy. Or maybe a separate
> > object "disks"/"other-disks"/etc. entirely? So as not have to filter out
> > the (non-)bootdisks again on the receiving end.
>
> Could be fine too, albeit I'd slightly prefer a single disk property, as it
> feels more naturally to me to filter on properties compared to checking, or
> having to combine, different array sets. But not too hard feelings here,
> maybe someone else got some (stronger) opinion.

If nobody else voices their opinion over that I'll go ahead with your
idea, a single property. Both have merits, but having them a single
property is more universal I guess.

>
> > While at it, the same would IMO make sense for NICs too, since one might
> > want to set up additional network devices too.
>
> good point.




More information about the pve-devel mailing list