[pve-devel] [PATCH installer v2 0/3] add check/rename for already-existing ZFS rpool

[Christoph Heiss]

v3 out: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064635.html

On Thu, Jul 11, 2024 at 11:56:37AM GMT, Christoph Heiss wrote:
> Pretty straight forward overall, implements a check for an existing
> `rpool` on the system and ask the user whether they would like to rename
> it, much in the same way as it works for VGs already.
>
> Without this, the installer would silently create a second (and thus
> conflicting) `rpool` and cause a boot failure after the installation,
> since it does not know which pool to import exactly.
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html
>
> Notable changes v1 -> v2:
>   * incorporated Aaron suggestions from v1
>   * rewrote tests to use a pre-defined input instead
>   * moved pool renaming to own subroutine
>   * documented all new subroutines
>   * split out tests into own patch
>
> Christoph Heiss (3):
>   proxmox: add zfs module for retrieving importable zpool info
>   test: add test cases for new zfs module
>   low-level: install: check for already-existing `rpool` on install
>
>  Proxmox/Install.pm        |  30 +++++++++++
>  Proxmox/Makefile          |   1 +
>  Proxmox/Sys/ZFS.pm        | 109 ++++++++++++++++++++++++++++++++++++++
>  test/Makefile             |   7 ++-
>  test/zfs-get-pool-list.pl |  57 ++++++++++++++++++++
>  5 files changed, 203 insertions(+), 1 deletion(-)
>  create mode 100644 Proxmox/Sys/ZFS.pm
>  create mode 100755 test/zfs-get-pool-list.pl
>
> --
> 2.44.0
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>