[pve-devel] [PATCH storage] volume import: assume target API version is at least 9

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 4 11:52:45 CEST 2024


Am 10/06/2024 um 11:04 schrieb Fiona Ebner:
> The storage API version has been bumped to at least 9 since
> libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where
> this change will come in, then the target node can be assumed to be
> running either Proxmox VE 8 or, during upgrade, the latest version of
> Proxmox VE 7.4, so it's safe to assume a storage API version of at
> least 9 in all cases.

it's fine by me that this was applied, but can we somehow assert this
assumption with an early `die if $apiver < 7` ? (maybe don't die if the
apiver could not be queried/parsed, i.e. is undef, if there are
legitimate situations where this can happen).

While just one major release difference might be seen as enough, we still
have users that are doing some more funky stuff on upgrades of clusters,
so if it's somewhat easy to assert the assumption, doing so can
definitively only help to improve UX.




More information about the pve-devel mailing list