[pve-devel] applied-series: [PATCH installer 0/4] tui: make disk options view tabbed on small screens

[Thomas Lamprecht]

Am 13/06/2024 um 13:53 schrieb Christoph Heiss:
> This adds a tabbed view component, for usage in the advanced disk
> options dialog when selecting ZFS or Btrfs. Works pretty much the same
> as its GUI counterpart, as much as that is possible.
> 
> It's currently only activated for small (<=80 columns) displays, to make
> disk selection a lot more usable in these cases. This mostly affects
> serial console installation, but possibly also installations using a
> virtual screen via IPMI/BMC.
> 
> Testing can be done using the `stty` to set specific terminal sizes,
> e.g. `stty columns 80 rows 24` for a standard VT100-spec terminal.
> 
> This componont/view may also be made the default for the advanced disk
> options dialog, to align the TUI with it GUI in more cases - I'm open
> for discussion on that. Would also simplify the code a lot, so there
> are certainly other benefits to it as well.
> 
> Christoph Heiss (4):
>   tui: fix some comment typos
>   tui: bootdisk: align btrfs dialog interface with zfs equivalent
>   tui: views: add new TabbedView component
>   tui: bootdisk: use tabbed view for disk options on small screens
> 
>  proxmox-tui-installer/src/views/bootdisk.rs   | 260 +++++++++++-------
>  proxmox-tui-installer/src/views/mod.rs        |   3 +
>  .../src/views/tabbed_view.rs                  | 196 +++++++++++++
>  3 files changed, 358 insertions(+), 101 deletions(-)
>  create mode 100644 proxmox-tui-installer/src/views/tabbed_view.rs
> 


applied series with Max's review trailers, thanks to both of you!