[pve-devel] [PATCH installer 0/4] tui: make disk options view tabbed on small screens

[Christoph Heiss]

On Tue, Jul 02, 2024 at 06:49:12PM GMT, Max Carrara wrote:
> On Thu Jun 13, 2024 at 1:53 PM CEST, Christoph Heiss wrote:
> > [..]
>
> Pretty neat! I like this a lot. See my entire feedback below.
>
> Leaving these here already so they don't get lost ;)
>
> Reviewed-by: Max Carrara <m.carrara at proxmox.com>
> Tested-by: Max Carrara <m.carrara at proxmox.com>
>

Thanks for the review!

[..]
> Testing
> -------
>
> * tty size: 60x15
>   - tabs work as intended, but the actual contents of the tabs get lost
>     for ZFS and BTRFS configurations, because there's not enough
>     vertical space
>   - it's (unsurprisingly) still possible to navigate through those
>     options, they're just not visible
>   - my suggestion would be to add some kind of scrolling view here,
>     though I'm not sure if we're aiming to support ttys that are *this*
>     small
>
> * tty size: 60x20
>   - same as above, except that the first (four) configuration options
>     in the advanced disk config tab are displayed, the other ones are
>     still lost

Well, 80x24 is basically the minimum size I'd reasonable support. It's
the resolution specified by the VT10x, so I would say it's safe to
assume that every video output supports at _least_ that. It's also
what's used for serial output. See also e.g. commit 3facbe51c [0] or the
VT100 technical manual [1] some more in-depth information.

And since the target is pretty defined for this (always fullscreen on
some video output, not some resizable graphical terminal window or
such), so I think supporting anything less would be a lot of work for
pretty much no return.

>
> * tty size: 80x24
>   - works pretty great, as there now is enough vertical space to display
>     everything
>   - haven't tested with multiple disks, but if a user wanted to e.g.
>     use ZFS with *a lot* of disks, there's still a risk that they might
>     run out of vertical space in the disk selection tab

The disk view is scrollable and should scroll as needed. Tested this
with ~12 disks.

>
> * tty size: 81x24
>   - feels awkward (as it does without this series :P) because the right
>     column in the advanced disk config tab gets squeezed (squoze?) too
>     much
>   - as you suggested above, the tab view could therefore IMO be made the
>     default in general, it just looks really neat overall; I personally
>     prefer it quite a lot over the old one

Yeah, that's what I thought, but I wasn't sure. It would also match the
GTK installer in that regard. The side-by-side is quite nice on wide
screens though, but no hard feelings :^)

[0] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=3facbe51c
[1] https://vt100.net/dec/ek-vt100-tm-002.pdf (page 21, "Format")