[pve-devel] applied: [PATCH v2 qemu] fix #4726: avoid superfluous check in vma code

Fiona Ebner f.ebner at proxmox.com
Wed Jul 3 11:03:21 CEST 2024


Am 14.06.24 um 13:00 schrieb Fiona Ebner:
> The 'status' pointer is dereferenced regardless of the NULL check,
> i.e. 'status->closed' is accessed after the branch with the check.
> Since all callers pass in the address of a struct on the stack, the
> pointer can never be NULL. Remove the superfluous check and add an
> assert instead.
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>

applied with Fabian's R-b given for v1, because it's the very same
change, but v2 has a slightly improved commit message.




More information about the pve-devel mailing list