[pve-devel] [PATCH common v3 1/3] tools: add check_list_empty function

Aaron Lauterer a.lauterer at proxmox.com
Wed Jul 3 10:01:42 CEST 2024


In some situations we don't want a total empty list. I opted for a
dedicated function instead of integrating it as error in the
`split_list` function. It is used in many places and the potential
fallout from unintended behavior changes is too big.

Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
changes since v2:
* newly added

 src/PVE/Tools.pm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 766c809..c8ac6f0 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -718,6 +718,14 @@ sub split_list {
     return @data;
 }
 
+sub check_list_empty {
+    my ($list) = @_;
+    if (scalar(PVE::Tools::split_list($list)) < 1) {
+	return 0;
+    }
+    return 1;
+}
+
 sub trim {
     my $txt = shift;
 
-- 
2.39.2





More information about the pve-devel mailing list