[pve-devel] [PATCH qemu-server v8 5/7] Permission check for virtiofs directory access

Fiona Ebner f.ebner at proxmox.com
Wed Jan 31 16:23:16 CET 2024


I feel like this patch should be squashed into the last one, because the
checks are an essential part of the feature and they always should be
applied together anyways.

Am 08.11.23 um 09:52 schrieb Markus Frank:
> +my sub check_vm_create_dir_perm {
> +    my ($rpcenv, $authuser, $vmid, $pool, $param) = @_;
> +
> +    return 1 if $authuser eq 'root at pam';
> +
> +    foreach my $opt (keys %{$param}) {

Style nit: please use "for"

Looks good to me otherwise :)




More information about the pve-devel mailing list