[pve-devel] [PATCH guest-common v8 2/7] add Dir mapping config

Fiona Ebner f.ebner at proxmox.com
Wed Jan 31 14:53:32 CET 2024

Am 31.01.24 um 14:42 schrieb Markus Frank:
>> I haven't looked at the code where this is used yet, so I'm as confused
>> as a user now ;) Does this affect mount points within the directory
>> (which the "sub" prefix suggests)? But it's a boolean, so how can I tell
>> "which directories"? The description should answer: When does it need to
>> be set/what effect does it have?
> I do not know why I wrote it like that.
> This is more correct:
>     description => "Announce that the directory contains other mounted
> file systems.",

What happens if there are nested mounts, but the flag is not set? Will
the directory be mounted without the nested mounts or will it fail? This
should be made clear to users.

>> What could also be mentioned for xattr and acl: do the underlying file
>> systems need to support these? What happens if they don't?
> ACLs and xattrs just get ignored if not supported.

Please include that in the description, thanks!

More information about the pve-devel mailing list