[pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement

Alexander Zeidler a.zeidler at proxmox.com
Mon Jan 29 10:51:36 CET 2024


On Wed, 2024-01-10 at 11:59 +0100, Alexander Zeidler wrote:
> On Wed, 2024-01-10 at 10:29 +0100, Thomas Lamprecht wrote:
> > any reason this is relevant you might want to add to the commit
> > message here?
> to avoid a failing null check and its error message. This confused
> users since the activation was successful anyway.
> 
> 
> > simple
> > 
> > return;
> > 
> > is slightly preferred for returning undef
> I considered using it, but then saw the established use of undef.
> Thanks!
> 
v2:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061506.html





More information about the pve-devel mailing list