[pve-devel] applied: [PATCH qemu-server v7 0/1] fix #4957: add vendor and product information passthrough for SCSI-Disks

[Fiona Ebner]

Am 10.01.24 um 13:45 schrieb Hannes Duerr:
> qemu-server:
> 
> Hannes Duerr (1):
>   fix #4957: add vendor and product information passthrough for
>     SCSI-Disks
> 
>  PVE/API2/Qemu.pm        | 39 +++++++++++++++++++++++++++++++++++++++
>  PVE/QemuServer.pm       | 12 ++++++++++++
>  PVE/QemuServer/Drive.pm | 24 ++++++++++++++++++++++++
>  3 files changed, 75 insertions(+)
> 
> 
> Summary over all repositories:
>   3 files changed, 75 insertions(+), 0 deletions(-)
> 

applied, thanks!

Squashed in a few style changes that didn't warrant a new version IMHO:
- You can use up to 100 characters per line, no need to split function
calls early, if they can fit that limit
- The exception message should be for raised for the config option, not
the sub-option, e.g. 'scsi0' instead of 'product'
- Also fixed the style for the exception (missing trailing comma,
indentation, message missing a space):

> -               product => "Passing of product information is only supported for".
> -               "'scsi-hd' and 'scsi-cd' devices (e.g. not pass-through)."
> +               $opt => "Passing of product information is only supported for 'scsi-hd' and "
> +                   ."'scsi-cd' devices (e.g. not pass-through).",