[pve-devel] [PATCH widget-toolkit] certificates: don't display name if there is no name

Maximiliano Sandoval m.sandoval at proxmox.com
Thu Jan 18 15:14:10 CET 2024


The default certificate does not have a name.

Reported-by: Dietmar Maurer <dietmar at proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 src/panel/Certificates.js | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/panel/Certificates.js b/src/panel/Certificates.js
index a522ab6..f924512 100644
--- a/src/panel/Certificates.js
+++ b/src/panel/Certificates.js
@@ -237,10 +237,16 @@ Ext.define('Proxmox.panel.Certificates', {
 	    {
 		xtype: 'proxmoxButton',
 		text: gettext('Delete Custom Certificate'),
-		confirmMsg: rec => Ext.String.format(
-		    gettext('Are you sure you want to remove the certificate used for {0}'),
-		    me.certById[rec.id].name,
-		),
+		confirmMsg: function(rec) {
+		    let cert = me.certById[rec.id];
+		    if (cert.name) {
+			return Ext.String.format(
+			    gettext('Are you sure you want to remove the certificate used for {0}'),
+			    cert.name,
+			);
+		    }
+		    return Ext.String.format(gettext('Are you sure you want to remove the certificate'));
+		},
 		callback: () => me.reload(),
 		selModel: me.selModel,
 		disabled: true,
-- 
2.39.2





More information about the pve-devel mailing list