[pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

[Stefan Hanreich]

On 12/22/23 22:27, DERUMIER, Alexandre wrote:
> Hi,
> I'll be on holiday next week (I'll be back the 2 january).
> 
> 
> I'll look at QinQ when I'll be back.

I've had another look at this patch series and I think I found the
reason for the issue(s) I encountered during my testing.

One issue is related to the new IP forwarding settings. It seems like
they are not applying. I've looked at the ifquery output after creating
a QinQ / VLAN zone with DHCP enabled:

  {
    "name": "qinq5",
    "auto": true,
    "config": {
      "bridge-ports": "z_qinq5.456",
      "bridge-stp": "no",
      "bridge-fd": "0",
      "ip-forward": "on",
      "address": "172.16.5.1/32"
    },
    "config_status": {
      "bridge-ports": "pass",
      "bridge-stp": "pass",
      "bridge-fd": "pass",
      "ip-forward": "fail",
      "address": "pass"
    },
    "status": "fail"
  },
  {
    "name": "vlan4",
    "auto": true,
    "config": {
      "bridge-ports": "ln_vlan4",
      "bridge-stp": "no",
      "bridge-fd": "0",
      "ip-forward": "on",
      "address": "172.16.4.1/32"
    },
    "config_status": {
      "bridge-ports": "pass",
      "bridge-stp": "pass",
      "bridge-fd": "pass",
      "ip-forward": "fail",
      "address": "pass"
    },
    "status": "fail"
  },

It seems like the ip-forward settings do not get applied and therefore
the command 'fails'. The bridges are up and working but IP forwarding is
enabled:

root at hoan-02:~# cat /proc/sys/net/ipv4/conf/vlan4/forwarding
1

root at hoan-02:~# cat /proc/sys/net/ipv4/conf/qinq5/forwarding
1


The other issue was using QinQ zone with a bridge that has no bridge
port configured and is not vlan-aware. In that case status is checking
for the existence of the sv_<id> interface but it doesn't exist since
there isn't a bridge port.
This is also occuring without this patch, so no show stopper here imo.

> It just miss the ip for dhcpserver different than gateway for ipv6
> handling for vlan/qinq/vxlan, but it should be easy to implement.
> 
> Also, for ipv6 in vrf, it need a patch for dnsmasq, so I think this
> will need to proxmox dnsmasq package version.