[pve-devel] [PATCH widget-toolkit] ui: repo status: Simplify logic for adding warnings

Fiona Ebner f.ebner at proxmox.com
Mon Feb 19 13:46:11 CET 2024

Am 07.12.23 um 14:11 schrieb Maximiliano Sandoval:
> The strings were hard to translate and required some tricks like passing
> 'Ceph ' as an argument. The `/main` part was also removed to simplify
> the flow and UX.

But people who have a Ceph repository with 'main' component configured
might be confused when getting a warning that only mentions

It's only relevant for Ceph Quincy and it turns out that the warnings
are currently only displayed for Ceph Reef repositories, because the UI
doesn't expect multiple Ceph versions. So I'd be fine with dropping the
'/main' after all.

Could you take a stab at fixing handling for multiple Ceph versions in a
follow-up? I.e. fix updateStandardRepos() to detect which version is
actually configured and only consider the statuses from those, as well
as displaying a warning if there are mixed Ceph versions configured.

> Suggested-by: Dietmar Maurer <dietmar at proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>

More information about the pve-devel mailing list